4 Posts
Doug S
7 years ago
Topic

https://www.seblod.com/community/forums/fields-plug-ins/free-button-field-settings-for-delete-article


The problem in the link above still exists in Seblod 3.10.0.  I made a delete button and if I have confirmation on, the confirmation box pops up, but when I confirm, the delete is not done...nothing happens.  When I turn confirmation off, the row is removed, but I do need the confirmation feature to work.  When will this be fixed?  thank you

Get a Book for SEBLOD
251 Posts
Viktor Iwan
7 years ago
3
Level 1

Can you try with icon field instead of free button?  Need to know if its js problem or not..  Is the console log free of error log? 

248 Posts
Giuse
7 years ago
2
Level 2

Same problem for me. There is no javascript error (checked with chrome console). Do you open the issue on GitHub?

thanks

Giuse

251 Posts
Viktor Iwan
7 years ago
1
Level 3

Try with protostar template.. Is the issue still happen? 

248 Posts
Giuse
7 years ago
0
Level 4

yes, nothing happens after clicking on the confirmation popup also with protostar.

cheers

Giuse

251 Posts
Viktor Iwan
7 years ago
0
Level 1

Yes Confirmed ! it is a bug and i build the cure

1. download the file here : http://joomlamastery.com/button_free.zip

2. replace the old button_free.php in (plugins/cck_field/button_free/button_free.php with the new one

3. Enjoy your new delete

@Klass, can you help me make the pull request on this one ? there was the a missing logic when the button_link is set to "content_delete", please check my zip file and compare

4229 Posts
Kadministrator
7 years ago
0
Level 1

Hi Viktor

it is best that you learn to use git & github (Github is basically extended version of git), it is not hard to make a pull request. 

a) make account on github an create a fork of seblod

https://help.github.com/categories/collaborating-with-issues-and-pull-requests/

b) checkout your seblod fork to your computer. Most IDE clients will have git or github options built-in, otherwise you can use git or github client

https://help.github.com/articles/set-up-git/#platform-windows

c) make a new branch from master branch locally

d) implement changes

e) commit changes locally and push them ( back to your fork on github)

f) Now you can use github interface to create pull request

https://help.github.com/articles/creating-a-pull-request-from-a-fork/

You will also need to do this from time to time to keep your fork synched with main repository

https://help.github.com/articles/syncing-a-fork/

179 Posts
carin
7 years ago
0
Level 1

Viktors fix does not do anything on my site, no difference to the old behaviour - nothing happens after confirmation. Did anyone get the delete to work in the meantime?

PCo
7 years ago
0
Level 1

I found an error on Google Chrome, since v58.0 there came a new info handler...

[Violation] 'click' handler took 1375ms

This message is not an error (got it via setting the error level to verbose) should definitely not lead to a cancelling of the script, why I read a lot at the net for the last hour. In first instance I thought it could be brought together with the new policy of ssl forms, but I could not verify this thesis at a correct ssl encrypted (Let's Encrypt) site.

Finally I found out, this should be caused by an inappropriate library or script - but I still have no idea how it could be solved without rewriting the jquery script itself. I tried the created button at a list and the form itself - at both the click does not get to an end IF the alert box is set to on. 

The html code of the button is at both types:

<div class="btn-wrapper" id="toolbar-delete">
	<button class="btn btn-small" onclick="if(!confirm('Sollen die ausgewählten Einträge wirklich gelöscht werden?')){return false;}" href="#"><i class="icon-delete"></i> </button></div>

Just an idea, could it be solved if we move the onclick directly to the href attribute?

Regards, Pierre.

248 Posts
Giuse
7 years ago
0
Level 1

Confirmation delete on link is fixed with 3.12.2

cheers

Giuse

Get a VIP membership